Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make number input immutable #545

Merged
merged 2 commits into from
Mar 21, 2022
Merged

refactor: make number input immutable #545

merged 2 commits into from
Mar 21, 2022

Conversation

xDivisionByZerox
Copy link
Member

@xDivisionByZerox xDivisionByZerox commented Feb 22, 2022

Created in relation to #328 .

  • destruct the input the local scoped variables
  • rewrite the test case

@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner February 22, 2022 21:28
@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #545 (248acc0) into main (c51fb15) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 248acc0 differs from pull request most recent head 7b7614a. Consider uploading reports for the commit 7b7614a to get more accurate results

@@            Coverage Diff             @@
##             main     #545      +/-   ##
==========================================
- Coverage   99.33%   99.33%   -0.01%     
==========================================
  Files        1920     1920              
  Lines      176488   176443      -45     
  Branches      910      898      -12     
==========================================
- Hits       175310   175264      -46     
- Misses       1122     1123       +1     
  Partials       56       56              
Impacted Files Coverage Δ
src/datatype.ts 99.66% <100.00%> (-0.01%) ⬇️
src/vendor/unique.ts 93.54% <0.00%> (-1.62%) ⬇️
src/image_providers/lorempicsum.ts 93.96% <0.00%> (-0.48%) ⬇️
src/image_providers/lorempixel.ts 91.75% <0.00%> (-0.23%) ⬇️
src/system.ts 96.37% <0.00%> (-0.11%) ⬇️
src/image_providers/unsplash.ts 98.66% <0.00%> (-0.06%) ⬇️
src/random.ts 99.22% <0.00%> (-0.01%) ⬇️
src/date.ts 100.00% <0.00%> (ø)
src/iban.ts 100.00% <0.00%> (ø)
src/definitions/utils.ts 100.00% <0.00%> (ø)
... and 2 more

@ST-DDT ST-DDT linked an issue Feb 22, 2022 that may be closed by this pull request
@ST-DDT ST-DDT added this to the v6.1 - First bugfixes milestone Feb 22, 2022
@ST-DDT ST-DDT added the c: bug Something isn't working label Feb 22, 2022
ST-DDT
ST-DDT previously approved these changes Feb 22, 2022
@ST-DDT ST-DDT requested a review from a team February 22, 2022 22:34
prisis
prisis previously approved these changes Mar 1, 2022
Shinigami92
Shinigami92 previously approved these changes Mar 10, 2022
test/datatype.spec.ts Show resolved Hide resolved
@Shinigami92 Shinigami92 added the p: 1-normal Nothing urgent label Mar 15, 2022
@ST-DDT ST-DDT dismissed stale reviews from prisis and themself via a1e86e6 March 21, 2022 10:04
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Mar 21, 2022
@Shinigami92 Shinigami92 enabled auto-merge (squash) March 21, 2022 13:18
@Shinigami92 Shinigami92 merged commit 9ab0825 into faker-js:main Mar 21, 2022
@xDivisionByZerox xDivisionByZerox deleted the refactor/number-input-immutable branch April 15, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datatype.number is not immutable
4 participants